feat(kubernetes): Add report flag for summary #2112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenrumney
changed the title
owenrumney
force-pushed
the
owenr-add-k8s-report-summary
branch
from
6675ab1
to
3cda6f8
Compare
knqyf263
reviewed
May 13, 2022
pkg/commands/app.go
Outdated
| reportFlag = cli.StringFlag{ | ||
| Name: "report", | ||
| Value: "json", | ||
| Usage: "specify a report format for the output. (json,summary default: json)", |
There was a problem hiding this comment.
IMHO, --report is different from --format. --report is how we aggregate/summarize the result and --format is the format like table and json. So, --report nsa --format table and --report nsa --format json both should be available. Looks like they are mixing now.
If it is confusing, we can consider a better name than --report.
There was a problem hiding this comment.
The default value of --format is table and --report is summary. There are two available combinations for now.
Default:
--report summary --format table
Also:
--report all --format json
We should display an error in the following case at the moment. We will support it in the future.
--report summary --format json
--report all --format table
added 4 commits
May 13, 2022 18:16
Signed-off-by: Owen Rumney <owen.rumney@aquasec.com>
Signed-off-by: Owen Rumney <owen.rumney@aquasec.com>
Signed-off-by: Owen Rumney <owen.rumney@aquasec.com>
Signed-off-by: Owen Rumney <owen.rumney@aquasec.com>
owenrumney
force-pushed
the
owenr-add-k8s-report-summary
branch
from
7df33d6
to
4343662
Compare
added 2 commits
May 13, 2022 18:30
Signed-off-by: Owen Rumney <owen.rumney@aquasec.com>
liamg
pushed a commit
that referenced
this pull request
Jun 7, 2022
* feat(k8s): Add report flag for summary * chore: add headings to the severity columns * chore: make the default output of k8s summary table Signed-off-by: Owen Rumney <owen.rumney@aquasec.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for using
--report summarywith thekubernetescommandChecklist