fix(php): skip composer.lock inside vendor folder
#2718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knqyf263
reviewed
Aug 17, 2022
| @@ -25,6 +26,21 @@ var requiredFiles = []string{types.ComposerLock} | |||
| type composerLibraryAnalyzer struct{} | |||
|
|
|||
| func (a composerLibraryAnalyzer) Analyze(_ context.Context, input analyzer.AnalysisInput) (*analyzer.AnalysisResult, error) { | |||
| // we should skip `composer.lock` inside `vendor` folder | |||
There was a problem hiding this comment.
We should do that in Required.
| if s == "vendor" { | ||
| path := filepath.Join(subDirs[:i]...) | ||
| f := filepath.Join(path, file) | ||
| if _, err := os.Stat(f); err == os.ErrNotExist { |
There was a problem hiding this comment.
os.Stat doesn't work if it is from a tar file.
knqyf263
reviewed
Aug 23, 2022
Co-authored-by: Teppei Fukuda <knqyf263@gmail.com>
knqyf263
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
trivyscanscomposer.lockfiles in the vendor folder, but these don't reflect what is really installed.composer.lockfiles in the vendor folder should be ignored.before:
after:
Related issues
Checklist