Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: url validaton failures #2783

Merged
merged 1 commit into from
Aug 30, 2022
Merged

fix: url validaton failures #2783

merged 1 commit into from
Aug 30, 2022

Conversation

samm-git
Copy link
Contributor

@samm-git samm-git commented Aug 26, 2022

Description

While analyzing failure of the report schema validation i found URL looks like that: "https://ubuntu.com/security/notices/USN-5051-4 (regression only in trusty/esm)". This causing gitlab to mark report as invalid as its failing to validate against the schema. Patch provided just using first word of the url word.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

While analyzing failure of the report schema validation i found URL looks like that: `https://ubuntu.com/security/notices/USN-5051-4 (regression only in trusty/esm)`. This causing gitlab to mark report as invalid. Patch provided just using first word of the url word.
@CLAassistant
Copy link

CLAassistant commented Aug 26, 2022

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@samm-git samm-git changed the title fix(gitlab): url validaton failures fix: url validaton failures Aug 26, 2022
@knqyf263 knqyf263 merged commit 2580ea1 into aquasecurity:main Aug 30, 2022
@knqyf263
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants