Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Helm also take into account files with .yml file extension #2928

Merged
merged 1 commit into from Sep 21, 2022
Merged

fix: Helm also take into account files with .yml file extension #2928

merged 1 commit into from Sep 21, 2022

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Sep 21, 2022 •
edited

Description

YAML files can also have the .yml file extension. So the helm config
should take that into account.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

owenrumney
owenrumney approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@owenrumney owenrumney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JAORMX
fix(cli): config/helm: also take into account files with .yml
c06b1bb 
YAML files can also have the `.yml` file extension. So the helm config
should take that into account.

Signed-off-by: Juan Antonio Osorio <juan.osoriorobles@eu.equinix.com>
@owenrumney owenrumney changed the title fix(cli): config/helm: also take into account files with .yml fix: Helm also take into account files with .yml file extension Sep 21, 2022
@owenrumney owenrumney merged commit 0c1a42d into aquasecurity:main Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenrumney owenrumney owenrumney approved these changes

@liamg liamg Awaiting requested review from liamg

@knqyf263 knqyf263 Awaiting requested review from knqyf263

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

config/helm: files with .yml extension are ignored
2 participants
@JAORMX @owenrumney