Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sbom): ref generation if serialNumber is empty when input is cyclonedx file #3000

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

DmitriyLewen
Copy link
Contributor

Description

serialNumber field is optional: https://cyclonedx.org/docs/1.4/json/#serialNumber
Changed ref generation if serialNumber is empty when input is cyclonedx file.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this Oct 7, 2022
@DmitriyLewen DmitriyLewen marked this pull request as ready for review October 7, 2022 08:02
@knqyf263 knqyf263 merged commit c2eb6ee into main Oct 11, 2022
@knqyf263 knqyf263 deleted the fix/bom-serial-number-is-empty branch October 11, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants