Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sbom): Bump in-toto-golang with correct CycloneDX predicate #3068

Merged
merged 20 commits into from
Oct 25, 2022
Merged

fix(sbom): Bump in-toto-golang with correct CycloneDX predicate #3068

merged 20 commits into from
Oct 25, 2022

Conversation

L1ghtman2k
Copy link
Contributor

@L1ghtman2k L1ghtman2k commented Oct 23, 2022

Description

Bump in-toto-golang lib, with the correct CycloneDX.

Currently, the used value is: https://cyclonedx.org/schema, however, it should be https://cyclonedx.org/bom.

This would also make trivy compatible with tools like cosign, and would allow trivy to scan SBOMs with a correct predicate: sigstore/cosign#2368

This introduces potentially breaking changes, as attestations with the previous cyclonedx predicate(https://cyclonedx.org/schema) would no longer be scannable by trivy sbom /path/to/report.cdx.intoto.jsonl command

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@L1ghtman2k
Copy link
Contributor Author

L1ghtman2k commented Oct 23, 2022

(Had to recreate the PR, because for some reason my old PR shows big diff)

@knqyf263 knqyf263 merged commit f4e970f into aquasecurity:main Oct 25, 2022
@knqyf263
Copy link
Collaborator

Thanks!

@knqyf263 knqyf263 changed the title fix(misconf): Bump in-toto-golang with correct CycloneDX predicate fix(sbom): Bump in-toto-golang with correct CycloneDX predicate Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants