Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: load compliance report from file system #3161

Merged
merged 11 commits into from
Nov 20, 2022
Merged

fix: load compliance report from file system #3161

merged 11 commits into from
Nov 20, 2022

Conversation

chen-keinan
Copy link
Contributor

Signed-off-by: chenk hen.keinan@gmail.com

Description

Load compliance report from file system

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).

@chen-keinan chen-keinan marked this pull request as draft November 13, 2022 07:46
@chen-keinan chen-keinan marked this pull request as ready for review November 13, 2022 07:55
josedonizetti
josedonizetti approved these changes Nov 13, 2022
View reviewed changes
Copy link
Contributor

@josedonizetti josedonizetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only one typo to fix.

knqyf263
knqyf263 reviewed Nov 20, 2022
View reviewed changes
pkg/flag/report_flags.go Outdated Show resolved Hide resolved
pkg/compliance/spec/compliance.go Outdated Show resolved Hide resolved
docs/docs/kubernetes/cli/compliance.md Outdated Show resolved Hide resolved
docs/docs/kubernetes/cli/compliance.md Outdated Show resolved Hide resolved
@chen-keinan
fix: load compliance report from file system
d76f04f 
Signed-off-by: chenk <hen.keinan@gmail.com>
@chen-keinan
fix: load compliance report from file system
6aaca50 
Signed-off-by: chenk <hen.keinan@gmail.com>
@chen-keinan
fix: load compliance report from file system
4133fb5 
Signed-off-by: chenk <hen.keinan@gmail.com>
@chen-keinan
fix: load compliance report from file system
4d3cba6 
Signed-off-by: chenk <hen.keinan@gmail.com>
@chen-keinan
fix: exclude --compliance flag from non relevant sub-comands
01e6f6b 
Signed-off-by: chenk <hen.keinan@gmail.com>
@chen-keinan
feat: load custom compliance report from file system
d161bab 
Signed-off-by: chenk <hen.keinan@gmail.com>
@chen-keinan
feat: load custom compliance report from file system
0598abd 
Signed-off-by: chenk <hen.keinan@gmail.com>
@chen-keinan
feat: load custom compliance report from file system
197039d 
Signed-off-by: chenk <hen.keinan@gmail.com>
@chen-keinan
feat: load custom compliance report from file system
d321ba4 
Signed-off-by: chenk <hen.keinan@gmail.com>
@chen-keinan
feat: load compliance report fs
77251fd 
Signed-off-by: chenk <hen.keinan@gmail.com>
@chen-keinan
Copy link
Contributor Author

chen-keinan commented Nov 20, 2022 •
edited
Loading

@knqyf263 thanks comments has been addressed

@chen-keinan
feat: load compliance report fs
23cb48f 
Signed-off-by: chenk <hen.keinan@gmail.com>
@knqyf263 knqyf263 merged commit fd5cafb into aquasecurity:main Nov 20, 2022
@itaysk itaysk mentioned this pull request Nov 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josedonizetti josedonizetti josedonizetti approved these changes

@knqyf263 knqyf263 knqyf263 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chen-keinan @josedonizetti @knqyf263