ci: add gpg signing for RPM packages #3612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afdesk
changed the title
knqyf263
reviewed
Mar 22, 2023
There was a problem hiding this comment.
And I want to make sure we don't break the dpkg installation.
https://aquasecurity.github.io/trivy/v0.38/getting-started/installation/#debianubuntu-official
goreleaser.yml
Outdated
Comment on lines
257
to
269
| - id: "gpg signing" | ||
| artifacts: all | ||
| signature: "${artifact}.gpg.sig" | ||
| args: | ||
| - "--batch" | ||
| - "-u" | ||
| - "{{ .Env.GPG_FINGERPRINT }}" | ||
| - "--output" | ||
| - "${signature}" | ||
| - "--detach-sign" | ||
| - "${artifact}" | ||
| output: true | ||
| stdin: '{{ .Env.GPG_PASSPHRASE }}' |
There was a problem hiding this comment.
Do we need this signing? If I understand correctly, isn't it relevant to rpm?
afdesk
changed the title
knqyf263
reviewed
Mar 23, 2023
docs/getting-started/installation.md
Outdated
| enabled=1 | ||
| gpgkey=https://aquasecurity.github.io/trivy-repo/deb/public.key |
There was a problem hiding this comment.
Should we copy the key under trivy-repo/rpm as it is currently located under trivy-repo/deb.
There was a problem hiding this comment.
yes, it makes sence.
I copied the public key and have created a PR aquasecurity/trivy-repo#24
|
I've created a PR aquasecurity/trivy-repo#25 but it should be merged after the first release with signed RPMs |
knqyf263
approved these changes
Mar 24, 2023
atombrella
pushed a commit
to atombrella/trivy
that referenced
this pull request
Mar 25, 2023
AnaisUrlichs
pushed a commit
to AnaisUrlichs/trivy
that referenced
this pull request
Mar 27, 2023
knqyf263
added a commit
to knqyf263/trivy
that referenced
this pull request
Apr 1, 2023
This reverts commit 67572df.
knqyf263
added a commit
that referenced
this pull request
Apr 1, 2023
Closed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added inline signatures for
RPMpackages.we use custom configuration GoReleaser's nFPM, so we need to set
$NFPM_ID_RPM_PASSPHRASEand$GPG_FILE.Related issues
Closes #1384
Checklist