Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sbom): add trivy version to spdx creators tool field #3756

Merged

Conversation

DmitriyLewen
Copy link
Contributor

Description

Creator.Tool field should contain Trivy version: https://spdx.github.io/spdx-spec/v2.3/document-creation-information/#68-creator-field.

spdx:

before:

Creator: Organization: aquasecurity
Creator: Tool: trivy

after:

Creator: Organization: aquasecurity
Creator: Tool: trivy-0.38.1

spdx-json:

before:

	"creationInfo": {
		"created": "2023-03-03T04:46:04.859719101Z",
		"creators": [
			"Tool: trivy",
			"Organization: aquasecurity"
		]
	},

after:

	"creationInfo": {
		"created": "2023-03-03T04:45:57Z",
		"creators": [
			"Tool: trivy-0.38.1",
			"Organization: aquasecurity"
		]
	},

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this Mar 3, 2023
@knqyf263 knqyf263 merged commit 60b7ef5 into aquasecurity:main Mar 3, 2023
atombrella pushed a commit to atombrella/trivy that referenced this pull request Mar 25, 2023
…y#3756)

* fix(sbom): add trivy version to spdx creators tool field

* refactor test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SPDX][TV/JSON] SBOM required field 'Creator' is missing/incorrect
2 participants