contrib: Add GitLab CI template to deeply integrated with GitLab Container Scanning #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
tnir
force-pushed
the
gitlab-ci-template
branch
from
56cc6ab
to
638f1c3
Compare
|
@tnir Thank you for the awesome contribution! We'll have a look soon. |
knqyf263
reviewed
Jan 22, 2020
tnir
force-pushed
the
gitlab-ci-template
branch
3 times, most recently
from
df726fe
to
94f3782
Compare
tnir
commented
Jan 23, 2020
tnir
force-pushed
the
gitlab-ci-template
branch
2 times, most recently
from
ac7e701
to
a3972fd
Compare
|
Templating does looks working well: https://gitlab.com/tnir/trivy-ci-test/-/jobs/412246842 |
mrueg
reviewed
Jan 23, 2020
mrueg
reviewed
Jan 23, 2020
contrib/Trivy.gitlab-ci.yml
Outdated
| - apk add --no-cache curl docker-cli | ||
| - docker login -u "$CI_REGISTRY_USER" -p "$CI_REGISTRY_PASSWORD" $CI_REGISTRY | ||
| - curl -sfL https://raw.githubusercontent.com/aquasecurity/trivy/master/contrib/install.sh | sh -s -- -b /usr/local/bin | ||
| - curl -sSL -o /tmp/trivy-gitlab.tpl https://github.com/aquasecurity/trivy/raw/master/contrib/gitlab.tpl |
There was a problem hiding this comment.
is there a way we could not fetch this from master? If the template changes and the downloaded binary does not support it, this could cause incompatibilities.
Maybe we can parse $(trivy --version) and pull from the tag instead?
There was a problem hiding this comment.
You are right. We should use environment variables to fix. With environment variables with the default value of Trivy version, (GitLab CI) users can inject arbitrary version of (Trivy-GitLab) template, which will reduce regression and be helpful for users of non-latest version GitLab.
tnir
force-pushed
the
gitlab-ci-template
branch
from
a3972fd
to
783eace
Compare
|
Task list was moved to the description of the PR. |
tnir
force-pushed
the
gitlab-ci-template
branch
3 times, most recently
from
04b9c09
to
8f0d8ac
Compare
mrueg
reviewed
Jan 24, 2020
tnir
force-pushed
the
gitlab-ci-template
branch
from
8f0d8ac
to
132b375
Compare
… Scanning Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
tnir
force-pushed
the
gitlab-ci-template
branch
from
132b375
to
350a96e
Compare
knqyf263
approved these changes
Jan 26, 2020
|
Thanks! Awesome work! |
GuaoGuao
pushed a commit
to GuaoGuao/trivy
that referenced
this pull request
Jun 24, 2020
… Scanning (aquasecurity#376) Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
liamg
pushed a commit
that referenced
this pull request
Jun 7, 2022
… Scanning (#376) Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
liamg
pushed a commit
that referenced
this pull request
Jun 7, 2022
liamg
pushed a commit
that referenced
this pull request
Jun 7, 2022
josedonizetti
pushed a commit
to josedonizetti/trivy
that referenced
this pull request
Jun 24, 2022
Co-authored-by: Liam Galvin <liam.galvin@aquasec.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds GitLab CI template with deep integration with GitLab Container Scanning (report) (part of GitLab Security Product)
cf. https://gitlab.com/gitlab-org/gitlab/blob/f156adcec4c48d304128f2a4a8987f9ad6408591/lib/gitlab/ci/templates/Security/Container-Scanning.gitlab-ci.yml
TODO
alpineversion to3.11- export TRIVY_VERSION_FOR_TEMPLATE=${TRIVY_VERSION_FOR_TEMPLATE:-v0.4.3}s!tnir/trivy!aquasecurity/trivy!after Modify template for GitLab Container Scanning #387 gets merged