Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nodejs): update logic for parsing pnpm lock files #4502

Merged
merged 2 commits into from
May 31, 2023

Conversation

DmitriyLewen
Copy link
Contributor

@DmitriyLewen DmitriyLewen commented May 30, 2023

Description

Fixed problem with deps parsing from registry.
Add support of lock file v6.

Related issues

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen changed the title fix(nodejs): update logic to parse pnpm lock files fix(nodejs): update logic for parsing pnpm lock files May 30, 2023
@DmitriyLewen DmitriyLewen marked this pull request as ready for review May 31, 2023 01:00
@knqyf263
Copy link
Collaborator

@DmitriyLewen Conflicting now

@DmitriyLewen
Copy link
Contributor Author

@knqyf263 fixed in c050728

@knqyf263 knqyf263 merged commit 18ce1c3 into aquasecurity:main May 31, 2023
9 checks passed
@kikar
Copy link

kikar commented May 31, 2023

When can we expect a new version with this fix?

@DmitriyLewen DmitriyLewen deleted the fix/pnpm-v6 branch May 31, 2023 05:59
@knqyf263
Copy link
Collaborator

https://github.com/aquasecurity/trivy/milestone/18

@danielchabr
Copy link

Hi @knqyf263, any chance the trivy-action will be updated to 0.42 any time soon too so that we can start using PNPM?
https://github.com/aquasecurity/trivy-action/tags

@knqyf263
Copy link
Collaborator

knqyf263 commented Jun 2, 2023

You can open PR in trivy-action.

@danielchabr
Copy link

ok, I've created aquasecurity/trivy-action#237

AnaisUrlichs pushed a commit to AnaisUrlichs/trivy that referenced this pull request Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PNPM scanning is broken, does not find any vulnerabilities
4 participants