Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vm): support post analyzer for vm command #4544

Merged
merged 8 commits into from
Jun 7, 2023
Merged

fix(vm): support post analyzer for vm command #4544

merged 8 commits into from
Jun 7, 2023

Conversation

masahiro331
Copy link
Collaborator

@masahiro331 masahiro331 commented Jun 3, 2023 •
edited
Loading

Description

Related issues

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@masahiro331 masahiro331 self-assigned this Jun 3, 2023
@knqyf263 knqyf263 mentioned this pull request Jun 4, 2023
Merged
6 tasks
@masahiro331 masahiro331 mentioned this pull request Jun 5, 2023
Merged
masahiro331
masahiro331 commented Jun 7, 2023
View reviewed changes
pkg/fanal/artifact/vm/vm.go
Comment on lines +48 to +49
Offline: a.artifactOption.Offline,
FileChecksum: a.artifactOption.FileChecksum,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I set it without thinking about anything, but I am reviewing it.

@masahiro331 masahiro331 marked this pull request as ready for review June 7, 2023 12:22
@knqyf263 knqyf263 merged commit 4a5b915 into aquasecurity:main Jun 7, 2023
11 checks passed
AnaisUrlichs pushed a commit to AnaisUrlichs/trivy that referenced this pull request Aug 10, 2023
@masahiro331 @AnaisUrlichs
fix(vm): support post analyzer for vm command (aquasecurity#4544)
8413b55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263 knqyf263 approved these changes

Assignees

@masahiro331 masahiro331

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(vm): add support for post-analyzer
2 participants
@masahiro331 @knqyf263