Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nodejs): change the type of the devDependencies field #4560

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

nikpivkin
Copy link
Contributor

Description

Scanning a v6 lock file with dev dependencies outputs the following error:

Analysis error: unable to parse pnpm-lock.yaml: failed to parse pnpm-lock.yaml: failed to parse pnpm-lock.yaml: decode error: yaml: unmarshal errors:
  line 8: cannot unmarshal !!map into string
…
  line 171: cannot unmarshal !!map into string

I changed the type of the devDependencies field, because in v6 lock file it is a structure and not a string.

Related issues

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nikpivkin nikpivkin requested a review from knqyf263 as a code owner June 5, 2023 08:58
@nikpivkin nikpivkin changed the title fix(pnpm): change the type of the devDependencies field fix(nodejs): change the type of the devDependencies field Jun 5, 2023
@afdesk afdesk marked this pull request as draft June 5, 2023 09:24
@knqyf263 knqyf263 requested a review from afdesk June 5, 2023 10:36
@afdesk afdesk marked this pull request as ready for review June 6, 2023 08:19
@knqyf263 knqyf263 merged commit 56cdc55 into aquasecurity:main Jun 6, 2023
8 checks passed
@nikpivkin nikpivkin deleted the fix/pnpm-dev-dep branch June 16, 2023 09:23
AnaisUrlichs pushed a commit to AnaisUrlichs/trivy that referenced this pull request Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PNPM scanning is broken
3 participants