Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misconf): deduplicate terraform results #4588

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

knqyf263
Copy link
Collaborator

@knqyf263 knqyf263 commented Jun 8, 2023

Description

#4457 caused duplicate misconfiguration results to be returned since all the nested terraform files are detected now.

This PR deduplicates terraform results.

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@knqyf263 knqyf263 self-assigned this Jun 8, 2023
@knqyf263 knqyf263 requested a review from afdesk June 8, 2023 11:50
Copy link
Contributor

@afdesk afdesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knqyf263 knqyf263 marked this pull request as ready for review June 8, 2023 12:13
@knqyf263 knqyf263 merged commit d52b0b7 into aquasecurity:main Jun 8, 2023
9 checks passed
@knqyf263 knqyf263 deleted the test/relative_path branch June 8, 2023 12:52
AnaisUrlichs pushed a commit to AnaisUrlichs/trivy that referenced this pull request Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants