Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(misconf): Support skipping services #4686

Merged
merged 9 commits into from
Jun 26, 2023
Merged

feat(misconf): Support skipping services #4686

merged 9 commits into from
Jun 26, 2023

Conversation

simar7
Copy link
Member

@simar7 simar7 commented Jun 21, 2023 •
edited
Loading

Description

Adds support for --skip-service flag.

$ trivy aws --skip-service=iam,s3

Will skip iam and s3 during the scan.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@simar7
feat(misconf): Add support for --skip-service flag.
8116e01 
Fixes: #4619
Signed-off-by: Simar <simar@linux.com>
@simar7
update docs
e5b6c60 
Signed-off-by: Simar <simar@linux.com>
@simar7 simar7 self-assigned this Jun 21, 2023
@simar7
update go mod
abbef91
@simar7
refactor processOptions to reduce cyclo complexity
9091d64 
Signed-off-by: Simar <simar@linux.com>
@simar7
fix a bug with multiple skip services
a0e6277 
Signed-off-by: Simar <simar@linux.com>
@simar7
refactor tests
4bbf84d 
Signed-off-by: Simar <simar@linux.com>
@simar7 simar7 marked this pull request as ready for review June 22, 2023 00:19
@simar7 simar7 added this to the v0.43.0 milestone Jun 22, 2023
@simar7 simar7 added scan/misconfiguration Issues relating to misconfiguration scanning kind/feature Categorizes issue or PR as related to a new feature. labels Jun 22, 2023
knqyf263
knqyf263 reviewed Jun 22, 2023
View reviewed changes
pkg/cloud/aws/commands/run.go Outdated Show resolved Hide resolved
pkg/cloud/aws/commands/run.go Outdated Show resolved Hide resolved
@simar7
use x/slice and x/xerrors
30b4b16 
Signed-off-by: Simar <simar@linux.com>
@simar7
go mod tidy
be33992
@simar7
lint
cc627c2
@knqyf263 knqyf263 added this pull request to the merge queue Jun 26, 2023
Merged via the queue into main with commit 5d73b47 Jun 26, 2023
27 checks passed
@knqyf263 knqyf263 deleted the support-skipping-services branch June 26, 2023 11:41
AnaisUrlichs pushed a commit to AnaisUrlichs/trivy that referenced this pull request Aug 10, 2023
@simar7 @AnaisUrlichs
feat(misconf): Support skipping services (aquasecurity#4686)
3ce8391 
* feat(misconf): Add support for `--skip-service` flag.

Fixes: aquasecurity#4619
Signed-off-by: Simar <simar@linux.com>

* update docs

Signed-off-by: Simar <simar@linux.com>

* update go mod

* refactor processOptions to reduce cyclo complexity

Signed-off-by: Simar <simar@linux.com>

* fix a bug with multiple skip services

Signed-off-by: Simar <simar@linux.com>

* refactor tests

Signed-off-by: Simar <simar@linux.com>

* use x/slice and x/xerrors

Signed-off-by: Simar <simar@linux.com>

* go mod tidy

* lint

---------

Signed-off-by: Simar <simar@linux.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263 knqyf263 approved these changes

@AnaisUrlichs AnaisUrlichs Awaiting requested review from AnaisUrlichs

@itaysk itaysk Awaiting requested review from itaysk

Assignees

@simar7 simar7

Labels
kind/feature Categorizes issue or PR as related to a new feature. scan/misconfiguration Issues relating to misconfiguration scanning
Projects
None yet
Milestone
v0.43.0
Development

Successfully merging this pull request may close these issues.

feat: Support skipping services for cloud scanning
2 participants
@simar7 @knqyf263