docs(image): fix the comment on the soft/hard link #4740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comment before the following w.processFile(filePath, tr, hdr.FileInfo(), analyzeFn) call says: // A symbolic/hard link or regular file will reach here. But defualt's processing causes the symbolic/hard link to not reach the processFile function location
|
|
zunlongzhou
changed the title
zunlongzhou
changed the title
|
Thanks. The source code is correct, and the comment is wrong. Could you update the comment? We need more discussion on the pros/cons of following symlinks. |
update tar.go comment
|
Thank you, I understand. I have updated the comments. |
|
Integration tests are failing due to a different reason. I'll fix it. |
knqyf263
changed the title
knqyf263
approved these changes
Jul 6, 2023
AnaisUrlichs
pushed a commit
to AnaisUrlichs/trivy
that referenced
this pull request
Aug 10, 2023
* Update tar.go The comment before the following w.processFile(filePath, tr, hdr.FileInfo(), analyzeFn) call says: // A symbolic/hard link or regular file will reach here. But defualt's processing causes the symbolic/hard link to not reach the processFile function location * Update tar.go update tar.go comment --------- Co-authored-by: knqyf263 <knqyf263@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment before the following w.processFile(filePath, tr, hdr.FileInfo(), analyzeFn) call says: // A symbolic/hard link or regular file will reach here. (pkg/fanal/walker/tar.go)
But defualt's processing causes the symbolic/hard link to not reach the processFile function location
Description
Related issues
Related PRs
Checklist