feat(misconf): Support custom data for rego policies for cloud #4745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
Hi Simar, I've removed this PR from the milestone as we usually have only issues in the milestone. |
Signed-off-by: Simar <simar@linux.com>
Signed-off-by: Simar <simar@linux.com>
Signed-off-by: Simar <simar@linux.com>
Signed-off-by: Simar <simar@linux.com>
simar7
changed the title
Signed-off-by: Simar <simar@linux.com>
AnaisUrlichs
reviewed
Jul 7, 2023
| @@ -969,6 +971,7 @@ func Test_Run(t *testing.T) { | |||
| cacheContent string | |||
| regoPolicy string | |||
| allServices []string | |||
| inputData string | |||
There was a problem hiding this comment.
Will we provide an example in the docs on using this?
There was a problem hiding this comment.
We already have that here https://aquasecurity.github.io/trivy/v0.43/docs/scanner/misconfiguration/custom/data/
This PR just extends that functionality to be used in Trivy Cloud Scanning.
AnaisUrlichs
approved these changes
Jul 10, 2023
Need this as OPA is currently broken on Windows open-policy-agent/opa#4521 Signed-off-by: Simar <simar@linux.com>
knqyf263
reviewed
Jul 13, 2023
pkg/cloud/aws/commands/run_test.go
Outdated
Comment on lines
974
to
976
| regoDir := filepath.Join("testdata", "Test_Run_Dir") | ||
| require.NoError(t, os.MkdirAll(regoDir, 0755)) | ||
| defer os.RemoveAll(regoDir) |
There was a problem hiding this comment.
I'm curious about the benefit of this change.
There was a problem hiding this comment.
pkg/commands/artifact/run.go
Outdated
| @@ -579,7 +579,7 @@ func initScannerConfig(opts flag.Options, cacheClient cache.Cache) (ScannerConfi | |||
| Trace: opts.Trace, | |||
| Namespaces: append(opts.PolicyNamespaces, defaultPolicyNamespaces...), | |||
| PolicyPaths: append(opts.PolicyPaths, downloadedPolicyPaths...), | |||
| DataPaths: opts.DataPaths, | |||
| DataPaths: append(opts.DataPaths, downloadedPolicyPaths...), | |||
There was a problem hiding this comment.
Why do we want to pass policy paths as data paths? The policies are loaded as data by mistake, no? I may be missing something.
There was a problem hiding this comment.
it was a typo, updated here 18b29d5
knqyf263
approved these changes
Jul 17, 2023
AnaisUrlichs
pushed a commit
to AnaisUrlichs/trivy
that referenced
this pull request
Aug 10, 2023
…ecurity#4745) * feat(misconf): Support custom data for cloud policies Signed-off-by: Simar <simar@linux.com> * use policyfs Signed-off-by: Simar <simar@linux.com> * refactor to reduce cyclomatic complexity Signed-off-by: Simar <simar@linux.com> * bump defsec * update docs Signed-off-by: Simar <simar@linux.com> * update test assertion Signed-off-by: Simar <simar@linux.com> * update test Need this as OPA is currently broken on Windows open-policy-agent/opa#4521 Signed-off-by: Simar <simar@linux.com> * fix data path * fix(mapfs): convert volume names into dirs * revert creating temp dirs --------- Signed-off-by: Simar <simar@linux.com> Co-authored-by: Teppei Fukuda <knqyf263@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for supplying custom data for rego policies.
Related issues
--config-datafor cloud scanning #4565Checklist