Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump github.com/docker/docker from v23.0.5+incompatible to v23.0.7-0.20230714215826-f00e7af96042+incompatible #4849

Merged
merged 4 commits into from
Jul 21, 2023
Merged

chore(deps): bump github.com/docker/docker from v23.0.5+incompatible to v23.0.7-0.20230714215826-f00e7af96042+incompatible #4849

merged 4 commits into from
Jul 21, 2023

Conversation

DmitriyLewen
Copy link
Contributor

@DmitriyLewen DmitriyLewen commented Jul 21, 2023 •
edited
Loading

Description

Go added breaking changes for Docker in 1.19.11 version and we are getting error in integration tests.
See more in #4848.

v23.0.7-0.20230714215826-f00e7af96042+incompatible version fixes this problem(moby/moby#45971).

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen marked this pull request as ready for review July 21, 2023 04:25
@DmitriyLewen DmitriyLewen changed the title test: use 1.19.10 version for integration tests chore(deps): bump github.com/docker/docker from v23.0.5+incompatible to v23.0.7-0.20230714215826-f00e7af96042+incompatible Jul 21, 2023
@knqyf263 knqyf263 enabled auto-merge July 21, 2023 08:57
@knqyf263 knqyf263 added this pull request to the merge queue Jul 21, 2023
Merged via the queue into aquasecurity:main with commit 78cc209 Jul 21, 2023
15 checks passed
@knqyf263 knqyf263 mentioned this pull request Jul 23, 2023
Closed
AnaisUrlichs pushed a commit to AnaisUrlichs/trivy that referenced this pull request Aug 10, 2023
@DmitriyLewen @AnaisUrlichs
chore(deps): bump github.com/docker/docker from v23.0.5+incompatible …
303bc87 
…to v23.0.7-0.20230714215826-f00e7af96042+incompatible (aquasecurity#4849)

* use 1.19.10 version for integration tests

* fix go-version field

* revert test workflow changes

* bump docker/docker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263 knqyf263 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(test): http: invalid Host header
2 participants
@DmitriyLewen @knqyf263