fix(misconf): add missing fields to proto #4861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knqyf263
reviewed
Jul 24, 2023
rpc/common/service.proto
Outdated
Comment on lines
68
to
69
| PolicyMetadata policy_metadata = 3; | ||
| CauseMetadata cause_metadata = 4; |
There was a problem hiding this comment.
We should not reuse the field number for some reasons. It leads to ambiguity.
https://protobuf.dev/programming-guides/proto3/#assigning
knqyf263
approved these changes
Jul 24, 2023
|
@nikpivkin Can you please resolve the conflict? |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
AnaisUrlichs
pushed a commit
to AnaisUrlichs/trivy
that referenced
this pull request
Aug 10, 2023
* fix(misconf): add missing fields to proto * mark deleted fields as reserved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some RPC structures do not correspond to similar structures from
fanal/types, so the results in server mode differ from the results in standalone mode.Related issues
Checklist