test(aws): move part of unit tests to integration #4884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simar7
reviewed
Jul 31, 2023
Comment on lines
-1004
to
985
| { | ||
| name: "try to call aws if cache is expired", | ||
| options: flag.Options{ | ||
| RegoOptions: flag.RegoOptions{SkipPolicyUpdate: true}, | ||
| AWSOptions: flag.AWSOptions{ | ||
| Region: "us-east-1", | ||
| Services: []string{"s3"}, | ||
| Account: "12345678", | ||
| }, | ||
| CloudOptions: flag.CloudOptions{ | ||
| MaxCacheAge: time.Minute, | ||
| }, | ||
| }, | ||
| cacheContent: "testdata/s3onlycache.json", | ||
| expectErr: true, | ||
| }, | ||
| { |
There was a problem hiding this comment.
Did you miss moving this test case over?
There was a problem hiding this comment.
@simar7
This test was successful because an error occurred due to the lack of credentials. I don't think this test is relevant at the moment, because if the cache has expired, then this error is ignored and all passed services are scanned.
simar7
approved these changes
Aug 2, 2023
knqyf263
approved these changes
Aug 2, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
auto-merge was automatically disabled
August 2, 2023 14:10
Head branch was pushed to by a user without write access
|
The PR was removed from the merge queue due to a failing test, but that test that failed seems unrelated === RUN TestContainerd_LocalImage
2023/08/02 11:30:04 🐳 Creating container for image ghcr.io/aquasecurity/trivy-test-images/containerd:latest
2023/08/02 11:30:04 ✅ Container created: e19a56b35e7d
2023/08/02 11:30:04 🐳 Starting container: e19a56b35e7d
2023/08/02 11:30:05 ✅ Container started: e19a56b35e7d
2023/08/02 11:30:05 🚧 Waiting for container id e19a56b35e7d image: ghcr.io/aquasecurity/trivy-test-images/containerd:latest. Waiting for: &{timeout:<nil> Log:containerd successfully booted Occurrence:1 PollInterval:100ms}
containerd_test.go:264:
Error Trace: /home/runner/work/trivy/trivy/pkg/fanal/test/integration/containerd_test.go:658
/home/runner/work/trivy/trivy/pkg/fanal/test/integration/containerd_test.go:264
Error: Received unexpected error:
failed to dial "/tmp/fanal3109783308/containerd/containerd.sock": connection error: desc = "transport: error while dialing: dial unix /tmp/fanal3109783308/containerd/containerd.sock: connect: permission denied"
Test: TestContainerd_LocalImage
2023/08/02 11:30:05 🐳 Terminating container: e19a56b35e7d
2023/08/02 11:30:05 🚫 Container terminated: e19a56b35e7d
--- FAIL: TestContainerd_LocalImage (0.74s)I'm going to try to requeue this PR for merging again. |
AnaisUrlichs
pushed a commit
to AnaisUrlichs/trivy
that referenced
this pull request
Aug 10, 2023
* test(aws): move part of unit tests to integration * fix typo * fix test --------- Co-authored-by: knqyf263 <knqyf263@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moved part of the unit tests that depend on the environment settings to the integration ones.
Related issues
Checklist