Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aws): resolve endpoint if endpoint is passed #4925

Merged
merged 4 commits into from
Aug 8, 2023
Merged

fix(aws): resolve endpoint if endpoint is passed #4925

merged 4 commits into from
Aug 8, 2023

Conversation

nikpivkin
Copy link
Contributor

@nikpivkin nikpivkin commented Aug 2, 2023 •
edited by simar7
Loading

Description

Passed endpoint is not overwritten for AWS configuration when creating sts, ebs and ami clients.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nikpivkin nikpivkin marked this pull request as ready for review August 2, 2023 08:42
@simar7
Copy link
Member

simar7 commented Aug 3, 2023

Looks like tests are red, @nikpivkin

@nikpivkin
Copy link
Contributor Author

@simar7 I fixed it.

@simar7 simar7 enabled auto-merge August 7, 2023 21:03
@simar7 simar7 added this pull request to the merge queue Aug 8, 2023
Merged via the queue into aquasecurity:main with commit e8cf281 Aug 8, 2023
13 checks passed
AnaisUrlichs pushed a commit to AnaisUrlichs/trivy that referenced this pull request Aug 10, 2023
@nikpivkin @AnaisUrlichs
fix(aws): resolve endpoint if endpoint is passed (aquasecurity#4925)
1bd5035 
* fix(aws): resolve endpoint to get identity if endpoint is passed

* resolve endpoint for ami and ebs

* return an error if aws region is missing
@nikpivkin nikpivkin deleted the fix/aws-endpoint branch August 15, 2023 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simar7 simar7 simar7 approved these changes

@knqyf263 knqyf263 Awaiting requested review from knqyf263 knqyf263 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(aws): resolve endpoint to get identity if endpoint is passed
2 participants
@nikpivkin @simar7