build: maximize available disk space for release #4937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knqyf263
reviewed
Aug 9, 2023
Comment on lines
112
to
114
| rm -r dist/build-* | ||
| rm -r dist/*tar.gz* | ||
| rm -r dist/*zip |
There was a problem hiding this comment.
Can we remove all files other than .deb and .rpm? And after using easimon/maximize-build-space, there is enough space. We may not need to remove these files.
find . -type f ! \( -name "*.rpm" -o -name "*.deb" \) -exec rm -f {} +
There was a problem hiding this comment.
what about *.dep.pem or *.dep.sig files?
i thought deploy scripts use them.
There was a problem hiding this comment.
I'm not sure, but easimon/maximize-build-space gives us enough space. We can remove this step for now.
knqyf263
force-pushed
the
ci/remove-unneeded-bins
branch
from
8e6e8b8
to
e474a4c
Compare
knqyf263
force-pushed
the
ci/remove-unneeded-bins
branch
from
b700d3e
to
0173a11
Compare
knqyf263
changed the title
knqyf263
approved these changes
Aug 9, 2023
AnaisUrlichs
pushed a commit
to AnaisUrlichs/trivy
that referenced
this pull request
Aug 10, 2023
* remove unneeded bins and archives * use jlumbroso/free-disk-space * remove repeating step * use maximize-build-space * build: remove unused step --------- Co-authored-by: knqyf263 <knqyf263@gmail.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We still have disk space problem.
Add next fixes for this:
This Action clears unneeded preinstalled pacakges, images, etc...
Tests:
https://github.com/DmitriyLewen/trivy/actions/runs/5804310282
Issue
Checklist