Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use testify instead of gotest.tools #4946

Merged
merged 1 commit into from
Aug 6, 2023
Merged

test: use testify instead of gotest.tools #4946

merged 1 commit into from
Aug 6, 2023

Conversation

nikpivkin
Copy link
Contributor

Description

We use testify in all tests.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nikpivkin nikpivkin marked this pull request as ready for review August 4, 2023 14:02
@knqyf263 knqyf263 added this pull request to the merge queue Aug 6, 2023
@knqyf263 knqyf263 mentioned this pull request Aug 6, 2023
Closed
2 tasks
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 6, 2023
@knqyf263 knqyf263 added this pull request to the merge queue Aug 6, 2023
Merged via the queue into aquasecurity:main with commit b544e0d Aug 6, 2023
12 checks passed
AnaisUrlichs pushed a commit to AnaisUrlichs/trivy that referenced this pull request Aug 10, 2023
@nikpivkin @AnaisUrlichs
use testify instead of gotest.tools (aquasecurity#4946)
add4cc9
@nikpivkin nikpivkin deleted the nik-testify branch August 15, 2023 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263 knqyf263 approved these changes

@josedonizetti josedonizetti Awaiting requested review from josedonizetti

@chen-keinan chen-keinan Awaiting requested review from chen-keinan chen-keinan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nikpivkin @knqyf263