Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: validate CycloneDX with the JSON schema #4956

Merged
merged 5 commits into from
Aug 8, 2023

Conversation

knqyf263
Copy link
Collaborator

@knqyf263 knqyf263 commented Aug 7, 2023

Description

Trivy CycloneDX output is sometimes invalid due to the breaking change in the CycloneDX spec, etc. This PR introduces tests to validate the CycloneDX format using the JSON schema. By validating it against tje JSON schema, we ensure that the format and the data it contains adhere to the expected structure, which is crucial for consistent and reliable processing.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@knqyf263 knqyf263 self-assigned this Aug 7, 2023
Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@knqyf263 knqyf263 marked this pull request as ready for review August 8, 2023 07:14
@knqyf263 knqyf263 added this pull request to the merge queue Aug 8, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 8, 2023
@knqyf263 knqyf263 added this pull request to the merge queue Aug 8, 2023
Merged via the queue into aquasecurity:main with commit d3a34e4 Aug 8, 2023
12 checks passed
@knqyf263 knqyf263 deleted the cdx_validation branch August 8, 2023 13:20
AnaisUrlichs pushed a commit to AnaisUrlichs/trivy that referenced this pull request Aug 10, 2023
* test: validate CycloneDX with the JSON schema

* fix(sbom): move licenses to `name` field in Cyclonedx format (aquasecurity#4941)

* use license.Name instead of Expression

* update tests

* test: add uuid package

* test: compare UUID

---------

Co-authored-by: DmitriyLewen <91113035+DmitriyLewen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants