Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(purl): skip local Go packages #5190

Merged
merged 3 commits into from Sep 20, 2023
Merged

fix(purl): skip local Go packages #5190

merged 3 commits into from Sep 20, 2023

Conversation

javierfreire
Copy link
Contributor

Description

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@CLAassistant
Copy link

CLAassistant commented Sep 14, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@javierfreire javierfreire changed the title fix(purl): trim a final slash fix(purl): skip local Go packages Sep 18, 2023
knqyf263
knqyf263 reviewed Sep 19, 2023
View reviewed changes
pkg/purl/purl.go Outdated Show resolved Hide resolved
pkg/purl/purl.go Outdated Show resolved Hide resolved
pkg/purl/purl.go Show resolved Hide resolved
pkg/sbom/spdx/marshal.go Outdated Show resolved Hide resolved
knqyf263
knqyf263 approved these changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@knqyf263 knqyf263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@knqyf263 knqyf263 added this pull request to the merge queue Sep 20, 2023
Merged via the queue into aquasecurity:main with commit 37af529 Sep 20, 2023
12 checks passed
@DmitriyLewen DmitriyLewen mentioned this pull request Oct 26, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263 knqyf263 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(purl): skip local Go packages
3 participants
@javierfreire @CLAassistant @knqyf263