Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update container_image.md #5182 #5193

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Conversation

mehrdadbn9
Copy link
Contributor

@mehrdadbn9 mehrdadbn9 commented Sep 15, 2023

remove --scanners none

Description

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

remove --scanners none
@CLAassistant
Copy link

CLAassistant commented Sep 15, 2023

CLA assistant check
All committers have signed the CLA.

@mehrdadbn9 mehrdadbn9 changed the title Update container_image.md docs:Update container_image.md #5182 Sep 15, 2023
@mehrdadbn9 mehrdadbn9 changed the title docs:Update container_image.md #5182 docs: Update container_image.md #5182 Sep 15, 2023
Comment on lines 174 to 177
If you just want to scan the image config.For example:

```shell
$ trivy image --scanners none --image-config-scanners secret vuln-image
$ trivy image --image-config-scanners secret vuln-image
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This command is the same as the above one. We can remove these lines.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate your kindness and you were right I omitted duplicate one.

duplicate command has been removed.
If you just want to scan the image config.For example:

```shell
$ trivy image --image-config-scanners secret vuln-image
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line breaks the document. You can build the doc with mage docs:serve and see how it looks.
https://aquasecurity.github.io/trivy/v0.45/community/contribute/pr/#documentation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i will check it and i will let you know tnx

@knqyf263 knqyf263 added this pull request to the merge queue Oct 16, 2023
Merged via the queue into aquasecurity:main with commit 57a1022 Oct 16, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: remove --scanners none
3 participants