Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use defined types #5225

Merged
merged 9 commits into from Sep 22, 2023
Merged

Conversation

knqyf263
Copy link
Collaborator

Description

The type of target is currently string such as "alpine", "python", "terraform", etc. It frequently leads to a bug due to type confusion. To prevent such mistakes, this PR introduces defined types for the target, and fixes found bugs thanks to the defined types.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

Signed-off-by: knqyf263 <knqyf263@gmail.com>
Signed-off-by: knqyf263 <knqyf263@gmail.com>
Signed-off-by: knqyf263 <knqyf263@gmail.com>
Signed-off-by: knqyf263 <knqyf263@gmail.com>
Signed-off-by: knqyf263 <knqyf263@gmail.com>
Signed-off-by: knqyf263 <knqyf263@gmail.com>
Signed-off-by: knqyf263 <knqyf263@gmail.com>
Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I have 1 question: Gomod analyzer should use analyzer.TypeGoMod, right?

analyzer.RegisterPostAnalyzer(types.GoMod, newGoModAnalyzer)

@knqyf263
Copy link
Collaborator Author

@DmitriyLewen You're right. Can you please fix it? I'm away from a computer.

Also, this change was probably made by a linter (misspel?). Can we add an exception for auto-fix?
1954bd2

@DmitriyLewen
Copy link
Contributor

You're right. Can you please fix it?

Changed in e1170d7

Can we add an exception for auto-fix?

Added licenCe word to ignore-words list for misspell linter in aad7837

@knqyf263 knqyf263 added this pull request to the merge queue Sep 22, 2023
Merged via the queue into aquasecurity:main with commit 44656f2 Sep 22, 2023
12 checks passed
@knqyf263 knqyf263 deleted the result_type branch September 22, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants