New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use defined types #5225
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: knqyf263 <knqyf263@gmail.com>
Signed-off-by: knqyf263 <knqyf263@gmail.com>
Signed-off-by: knqyf263 <knqyf263@gmail.com>
Signed-off-by: knqyf263 <knqyf263@gmail.com>
knqyf263
requested review from
josedonizetti,
chen-keinan and
simar7
as code owners
September 21, 2023 15:44
Signed-off-by: knqyf263 <knqyf263@gmail.com>
Signed-off-by: knqyf263 <knqyf263@gmail.com>
knqyf263
force-pushed
the
result_type
branch
2 times, most recently
from
September 21, 2023 20:09
fc2033f
to
2587c4b
Compare
Signed-off-by: knqyf263 <knqyf263@gmail.com>
knqyf263
force-pushed
the
result_type
branch
from
September 22, 2023 04:48
2587c4b
to
1954bd2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I have 1 question: Gomod analyzer should use analyzer.TypeGoMod
, right?
analyzer.RegisterPostAnalyzer(types.GoMod, newGoModAnalyzer) |
simar7
approved these changes
Sep 22, 2023
@DmitriyLewen You're right. Can you please fix it? I'm away from a computer. Also, this change was probably made by a linter (misspel?). Can we add an exception for auto-fix? |
DmitriyLewen
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The type of target is currently string such as "alpine", "python", "terraform", etc. It frequently leads to a bug due to type confusion. To prevent such mistakes, this PR introduces defined types for the target, and fixes found bugs thanks to the defined types.
Checklist