Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(misconf): Update refactored dependencies #5245

Merged
merged 24 commits into from
Nov 9, 2023
Merged

refactor(misconf): Update refactored dependencies #5245

merged 24 commits into from
Nov 9, 2023

Conversation

simar7
Copy link
Member

@simar7 simar7 commented Sep 25, 2023 •
edited
Loading

Description

This PR updates the defsec dependency along with the refactored subcomponents of it.

Related issues

Related PRs (need to be merged first)

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

simar7
simar7 commented Sep 28, 2023
View reviewed changes
go.mod Outdated
github.com/aquasecurity/defsec v0.92.0
github.com/aquasecurity/defsec v0.92.1-0.20230925225724-4b598f8ffb36
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: update this to latest defsec when aquasecurity/defsec#1460 is merged

@simar7 simar7 mentioned this pull request Nov 1, 2023
Closed
7 tasks
@simar7 simar7 mentioned this pull request Nov 1, 2023
Merged
1 task
@simar7 simar7 mentioned this pull request Nov 2, 2023
Merged
7 tasks
@nikpivkin nikpivkin mentioned this pull request Nov 7, 2023
Closed
@simar7 simar7 marked this pull request as ready for review November 7, 2023 22:41
@simar7 simar7 requested a review from knqyf263 as a code owner November 7, 2023 22:41
@simar7 simar7 requested a review from nikpivkin November 7, 2023 23:30
@simar7 simar7 self-assigned this Nov 7, 2023
nikpivkin
nikpivkin approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@nikpivkin nikpivkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knqyf263
Copy link
Collaborator

knqyf263 commented Nov 9, 2023 •
edited
Loading

I think we should announce the built-in policies will be downloaded from ghcr.io/aquasecurity/trivy-policies. The defsec bundle will not be updated, right? If so, older Trivy versions won't follow the policy updates.

@simar7
Copy link
Member Author

simar7 commented Nov 9, 2023

I think we should announce the built-in policies will be downloaded from ghcr.io/aquasecurity/trivy-policies. The defsec bundle will not be updated, right? If so, older Trivy versions won't follow the policy updates.

Good call. We do have --policy-bundle-repository for older users to use newer policies at the new location. We can include this information in the announcement.

@knqyf263
Copy link
Collaborator

knqyf263 commented Nov 9, 2023

We do have --policy-bundle-repository for older users to use newer policies at the new location. We can include this information in the announcement.

Yeah, it's nice. Those who want to keep using older versions can specify --policy-bundle-repository ghcr.io/aquasecurity/trivy-policies.

@knqyf263 knqyf263 added this pull request to the merge queue Nov 9, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 9, 2023
@knqyf263
Copy link
Collaborator

knqyf263 commented Nov 9, 2023

@simar7 Can you please resolve conflicts?

@knqyf263 knqyf263 added this pull request to the merge queue Nov 9, 2023
Merged via the queue into main with commit e7f6a5c Nov 9, 2023
18 checks passed
@knqyf263 knqyf263 deleted the defsec-refactor-update branch November 9, 2023 02:48
@Moniseeta Moniseeta mentioned this pull request Nov 14, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikpivkin nikpivkin nikpivkin approved these changes

@knqyf263 knqyf263 Awaiting requested review from knqyf263 knqyf263 is a code owner

Assignees

@simar7 simar7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor(misconf): Refactor defsec components
3 participants
@simar7 @knqyf263 @nikpivkin