Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Report error when os.CreateTemp fails (to be consistent with other uses) #5342

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

dougdonohoe
Copy link
Contributor

@dougdonohoe dougdonohoe commented Oct 5, 2023

Description

A error returned from os.CreateTemp is not wrapped in the case of docker and podman uses. This changes the code to be consistent with the two other uses, containerd and remote.

I ran into this and had no visibility as to why os.CreateTemp failed.

I didn't add tests given this is just a small change in-line with the existing examples.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@CLAassistant
Copy link

CLAassistant commented Oct 5, 2023

CLA assistant check
All committers have signed the CLA.

@dougdonohoe dougdonohoe changed the title Report error when os.CreateTemp fails (to be consistent with other uses) fix: Report error when os.CreateTemp fails (to be consistent with other uses) Oct 5, 2023
Copy link
Collaborator

@knqyf263 knqyf263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@knqyf263 knqyf263 added this pull request to the merge queue Oct 5, 2023
Merged via the queue into aquasecurity:main with commit ced54ac Oct 5, 2023
13 of 14 checks passed
@dougdonohoe
Copy link
Contributor Author

Thanks for quick review and merge 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants