-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(misconf): Support --ignore-policy
in config scans
#5359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simar <simar@linux.com>
5050ff4
to
eea7d15
Compare
Signed-off-by: Simar <simar@linux.com>
knqyf263
reviewed
Oct 13, 2023
nikpivkin
reviewed
Oct 13, 2023
nikpivkin
reviewed
Oct 13, 2023
nikpivkin
reviewed
Oct 13, 2023
nikpivkin
requested changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a few comments
nikpivkin
reviewed
Oct 13, 2023
nikpivkin
reviewed
Oct 13, 2023
190585b
to
a0d1e40
Compare
Looks like k8s tests are failing because of disk issues but we have #5387 in place |
a0d1e40
to
d70b1cc
Compare
knqyf263
reviewed
Oct 17, 2023
982d261
to
4626583
Compare
Signed-off-by: Simar <simar@linux.com>
4626583
to
a87414a
Compare
knqyf263
approved these changes
Oct 18, 2023
nikpivkin
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for passing
--ignore-policy
to ignore misconfiguration results in misconf scanning. Also correctly displays the exception count.Before
After
Related issues
Checklist