Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(misconf): Update --tf-exclude-downloaded-modules description #5419

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

simar7
Copy link
Member

@simar7 simar7 commented Oct 21, 2023

Description

Improve the help text for --tf-exclude-downloaded-modules flag.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@simar7 simar7 requested a review from nikpivkin October 21, 2023 03:20
@simar7 simar7 self-assigned this Oct 21, 2023
@simar7 simar7 marked this pull request as ready for review October 21, 2023 03:52
@simar7 simar7 requested a review from knqyf263 as a code owner October 21, 2023 03:52
@simar7 simar7 changed the title docs(misconf): Update tf-exclude-downloaded-modules description docs(misconf): Update --tf-exclude-downloaded-modules description Oct 21, 2023
Copy link
Contributor

@nikpivkin nikpivkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simar7
Copy link
Member Author

simar7 commented Oct 24, 2023

The documentation also needs to be updated: https://github.com/aquasecurity/trivy/blob/main/docs/docs/coverage/iac/terraform.md?plain=1#L36C41-L41

I think it still makes sense to me. What do you propose we update it to?

@nikpivkin
Copy link
Contributor

@simar7 This flag does not skip .terraform

If you don't want to scan modules downloaded into the .terraform directory

@simar7
Copy link
Member Author

simar7 commented Oct 24, 2023

@simar7 This flag does not skip .terraform

If you don't want to scan modules downloaded into the .terraform directory

OK - updated.

@knqyf263 knqyf263 added this pull request to the merge queue Oct 24, 2023
Merged via the queue into main with commit 53c9a7d Oct 24, 2023
21 checks passed
@knqyf263 knqyf263 deleted the docs/improve-help-text branch October 24, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs(cli): fix the description of the --tf-exclude-downloaded-modules flag
3 participants