Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(java): download java-db once #5442

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

DmitriyLewen
Copy link
Contributor

@DmitriyLewen DmitriyLewen commented Oct 25, 2023

Description

After #5273 we download java-db for each layer with jar files (for image mode), but this should be done once per run.
Also we need to create new Client for each PostAnalyze function instead of overwriting client from javaLibraryAnalyzer.

Related issues

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this Oct 25, 2023
@DmitriyLewen DmitriyLewen marked this pull request as ready for review October 25, 2023 07:11
@knqyf263 knqyf263 added this pull request to the merge queue Oct 26, 2023
Merged via the queue into aquasecurity:main with commit 26b4959 Oct 26, 2023
24 checks passed
knqyf263 pushed a commit that referenced this pull request Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(java): Trivy downloads trivy-java-db multiple times in one run
2 participants