Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct error mismatch causing race in fast walks #5516

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

lebauce
Copy link
Contributor

@lebauce lebauce commented Nov 5, 2023

Description

This PR is a follow up of #5482 and should have been part of it.
When using multiple workers, the same error is used by each of them, causing a data race.
err was used and is overwritten by the return value.

Related issues

  • Close #XXX

Related PRs

  • #XXX
  • #YYY

Remove this section if you don't have related PRs.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@knqyf263 knqyf263 added this pull request to the merge queue Nov 6, 2023
@knqyf263
Copy link
Collaborator

knqyf263 commented Nov 6, 2023

Thanks

Merged via the queue into aquasecurity:main with commit fed4710 Nov 6, 2023
13 checks passed
@lebauce lebauce deleted the fix-fast-walk-race branch November 6, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants