Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(flag): replace '--slow' with '--parallel' #5572

Merged
merged 9 commits into from
Nov 15, 2023
Merged

feat(flag): replace '--slow' with '--parallel' #5572

merged 9 commits into from
Nov 15, 2023

Conversation

knqyf263
Copy link
Collaborator

Description

We now need to control the number of parallels. This PR deprecates --slow and adds --parallel.

Before

$ trivy image --slow YOUR_IMAGE

After

$ trivy image --parallel 1 YOUR_IMAGE

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@knqyf263
feat(flag): add '--parallel'
e47d840 
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263
docs: update
c8eaa4c 
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263 knqyf263 self-assigned this Nov 14, 2023
@knqyf263 knqyf263 changed the title feat(flag): add '--parallel' feat(flag): replace '--slow' with '--parallel' Nov 14, 2023
@knqyf263 knqyf263 marked this pull request as ready for review November 14, 2023 06:58
@knqyf263
Copy link
Collaborator Author

@Moniseeta @santhosh1729 Please take a look.

DmitriyLewen
DmitriyLewen reviewed Nov 14, 2023
View reviewed changes
pkg/semaphore/semaphore.go Show resolved Hide resolved
pkg/commands/artifact/run.go Show resolved Hide resolved
docs/docs/references/configuration/cli/trivy_sbom.md Outdated Show resolved Hide resolved
pkg/flag/kubernetes_flags.go Show resolved Hide resolved
@knqyf263
fix: set parallel
3de5efd 
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263
fix: disable --parallel for SBOM scanning
ca71aac 
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263
Merge branch 'main' into add_parallel
9b8a290
@knqyf263
feat: auto-detect parallelism
c08df01 
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263
fix: process --parallel only when enabled
05716b8 
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263
test(integration): add '--parallel'
89dcc91 
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263
Merge branch 'main' into add_parallel
46e2113 
Signed-off-by: knqyf263 <knqyf263@gmail.com>
DmitriyLewen
DmitriyLewen approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knqyf263 knqyf263 added this pull request to the merge queue Nov 15, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 15, 2023
@knqyf263 knqyf263 added this pull request to the merge queue Nov 15, 2023
Merged via the queue into aquasecurity:main with commit ac0e327 Nov 15, 2023
17 checks passed
@knqyf263 knqyf263 deleted the add_parallel branch November 15, 2023 06:59
@aqua-bot aqua-bot mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmitriyLewen DmitriyLewen DmitriyLewen approved these changes

@tonaim tonaim Awaiting requested review from tonaim

Assignees

@knqyf263 knqyf263

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate '--slow' Flag in favor of universal '--parallel' flag
2 participants
@knqyf263 @DmitriyLewen