Added sarif template #558
Merged
Added sarif template #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@knqyf263 kindle review |
|
@simar7 Could you review this PR? We need to upload a SARIF file to GitHub actually and check how it looks on the UI. |
simar7
requested changes
Jul 13, 2020
|
Is this valid SARIF? For me it doesn't pass the validator checks. You can try this here https://sarifweb.azurewebsites.net/Validation
I think you could also use a simple JSON validator as it should pass that too. |
|
Furthermore, could you also add a test that would exercise this template? You can see an example here trivy/integration/client_server_test.go Lines 78 to 87 in aa20adb |
|
@simar7 fixed all comments, also validated the final output in Sarif validator |
simar7
reviewed
Jul 16, 2020
simar7
reviewed
Jul 16, 2020
simar7
approved these changes
Jul 17, 2020
liamg
pushed a commit
that referenced
this pull request
Jun 7, 2022
* Added sarif template * Updated readme * fixed tests * Added integration tests and fixed all sarif validations issues * Added tests for endWithPeriod * Fixed tests, and added sarif golden file * removed optional newline sequence
liamg
pushed a commit
that referenced
this pull request
Jun 20, 2022
* chore(deps): update defsec * fix: update tests with changes * fix test * fix: lint fixes Signed-off-by: Owen Rumney <owen.rumney@aquasec.com>
josedonizetti
pushed a commit
to josedonizetti/trivy
that referenced
this pull request
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue