-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vuln): remove duplicates in Fixed Version #5596
feat(vuln): remove duplicates in Fixed Version #5596
Conversation
@knqyf263 any chance you have time to review this? 🙏 |
Could you fix tests first? |
Done, sorry, I didn't realize that. |
Hm... this is strange case. @ilpianista do you know reason for this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @ilpianista
Thanks for your work!
I left 1 comment.
Can you also add a small test case to driver_test.go
to make sure your changes work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@knqyf263 take a look, when you have time, please
Description
Sometime, the Fixed Version column may contains the same versions repeatedly:
AFTER:
Checklist