Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(report): use time.Time for CreatedAt #5598

Merged
merged 1 commit into from
Nov 16, 2023
Merged

fix(report): use time.Time for CreatedAt #5598

merged 1 commit into from
Nov 16, 2023

Conversation

knqyf263
Copy link
Collaborator

@knqyf263 knqyf263 commented Nov 16, 2023 •
edited
Loading

Description

It's more human-readable.

Before

  "CreatedAt": 1629894030,

After

  "CreatedAt": "2021-08-25T12:20:30.000000005Z",

Related issues

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@knqyf263 knqyf263 self-assigned this Nov 16, 2023
@knqyf263
fix: use time.Time for CreatedAt
e26dd33 
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263 knqyf263 marked this pull request as ready for review November 16, 2023 05:00
@knqyf263 knqyf263 changed the title fix: use time.Time for CreatedAt fix(report): use time.Time for CreatedAt Nov 16, 2023
DmitriyLewen
DmitriyLewen approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knqyf263 knqyf263 added this pull request to the merge queue Nov 16, 2023
Merged via the queue into aquasecurity:main with commit ae4bcf6 Nov 16, 2023
14 checks passed
@knqyf263 knqyf263 deleted the fix/created_at branch November 16, 2023 06:05
@aqua-bot aqua-bot mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmitriyLewen DmitriyLewen DmitriyLewen approved these changes

@simar7 simar7 Awaiting requested review from simar7 simar7 is a code owner

Assignees

@knqyf263 knqyf263

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@knqyf263 @DmitriyLewen