Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Dagger integration section and cleanup Ecosystem CICD docs page #5608

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

jpadams
Copy link
Contributor

@jpadams jpadams commented Nov 17, 2023

Description

Adds a Dagger integration section and cleans up a couple of minor things on the Ecosystem CICD docs page.

There is a Dagger integration for Trivy that we want to share through the docs page, so I made an update. In the course of updating the page, I noticed that the Azure DevOps content was stuck in the middle of the GitHub Actions content, so I moved that out to stand alone. I also noticed that integrations were using H2 (##) markdown, but the Buildkite entry was using H3 (###), so I fixed that to make things consistent.

Related issues

Related PRs

  • none other than this one 😄

Remove this section if you don't have related PRs.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • n/a I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • n/a I've added usage information (if the PR introduces new options)
  • n/a I've included a "before" and "after" example to the description (if the PR is a user interface change).

Signed-off-by: Jeremy Adams <jeremy@dagger.io>
Signed-off-by: Jeremy Adams <jeremy@dagger.io>
Signed-off-by: Jeremy Adams <jeremy@dagger.io>
@CLAassistant
Copy link

CLAassistant commented Nov 17, 2023

CLA assistant check
All committers have signed the CLA.

@jpadams jpadams changed the title Add a Dagger integration section and cleanup Ecosystem CICD docs page docs: Add a Dagger integration section and cleanup Ecosystem CICD docs page Nov 17, 2023
Copy link
Contributor

@itaysk itaysk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @jpadams !

@jpadams jpadams changed the title docs: Add a Dagger integration section and cleanup Ecosystem CICD docs page docs: Add Dagger integration section and cleanup Ecosystem CICD docs page Nov 17, 2023
@itaysk itaysk added this pull request to the merge queue Nov 20, 2023
Merged via the queue into aquasecurity:main with commit 3c81727 Nov 20, 2023
8 of 9 checks passed
@jpadams jpadams deleted the cicd-md-cleanup-add-dagger branch November 20, 2023 03:43
@jpadams
Copy link
Contributor Author

jpadams commented Nov 20, 2023

@itaysk Thank you for the merge!

Not sure what needs to happen for this content to go live at https://aquasecurity.github.io/trivy/latest/ecosystem/cicd/.

Maybe a manual deploy of your static site? Not sure if I need to do something to trigger that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants