Fixed case when pre-release is in suffix #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knqyf263
reviewed
Jul 21, 2020
|
Could you try |
|
|
|
Yes, an error makes a user wonder if the result is incorrect. We have to handle the error as well. |
|
@knqyf263 updated error to debug |
|
Can we skip the case when the constraint is empty and suppress the error? |
|
@knqyf263 please check now |
knqyf263
approved these changes
Jul 22, 2020
liamg
pushed a commit
that referenced
this pull request
Jun 7, 2022
* Fixed case when pre-release is in suffix * moved regex to global scope * removed not needed code * Update error to debug * skip constraint when empty
liamg
pushed a commit
that referenced
this pull request
Jun 20, 2022
* fix(secrets): added allow rule for examples * test(secrets): added test for skip example file
josedonizetti
pushed a commit
to josedonizetti/trivy
that referenced
this pull request
Jun 24, 2022
) * feat: adding k8s rego line numbers * test: Add k8s rego tests * feat: added result metadata to advanced k8s policies * fix: rego for account tokens * fix(tests): fixing the rego tests for pss * fix: remaining opa tests * feat(scanning): Rego policy line numbers for K8s * fix(rego): fix opa formatting * fix(tests): fix broken tests * chore: merge in master * fix: remove dependence on the chartname being passed in Signed-off-by: Owen Rumney <owen.rumney@aquasec.com> Co-authored-by: Liam Galvin <liam.galvin@aquasec.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests added to cover scenarios when version contains pre-release in minor or patch version