Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(misconf): Add --misconfig-scanners option #5670

Merged
merged 6 commits into from
Nov 30, 2023

Conversation

simar7
Copy link
Member

@simar7 simar7 commented Nov 28, 2023

Description

Adds the --misconfig-scanners option to enable a subset of misconfiguration scanners.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@simar7 simar7 self-assigned this Nov 28, 2023
@simar7 simar7 marked this pull request as ready for review November 28, 2023 07:13
@simar7 simar7 requested review from nikpivkin and knqyf263 and removed request for knqyf263 November 28, 2023 07:13
Copy link
Contributor

@nikpivkin nikpivkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -73,6 +75,12 @@ var (
Default: fmt.Sprintf("%s:%d", policy.BundleRepository, policy.BundleVersion),
Usage: "OCI registry URL to retrieve policy bundle from",
}
MisconfigScannersFlag = Flag{
Name: "misconfig-scanners",
ConfigName: "misconfiguration.scanners",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small note: the documentation specifies the misconfiguration.type field.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, fixed

@knqyf263 knqyf263 added this pull request to the merge queue Nov 29, 2023
@knqyf263
Copy link
Collaborator

:shipit:

Merged via the queue into main with commit b5874e3 Nov 30, 2023
21 checks passed
@knqyf263 knqyf263 deleted the add-misconfig-scanners-options branch November 30, 2023 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(misconf): Selectively enable misconfiguration scanners
3 participants