Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added template fucntion to escape string before output #583

Merged
merged 2 commits into from Jul 31, 2020
Merged

Added template fucntion to escape string before output #583

merged 2 commits into from Jul 31, 2020

Conversation

rahul2393
Copy link
Contributor

Unescaped strings like https://gist.github.com/simar7/da144ed1d9b6d53f5c9af1e9282a3e68#file-gistfile1-txt-L81-L84 in output SARIF results in invalid SARIF file, this PR will fix the case

@codecov
Copy link

codecov bot commented Jul 31, 2020

Codecov Report

Merging #583 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #583      +/-   ##
==========================================
+ Coverage   55.78%   55.84%   +0.06%     
==========================================
  Files          44       44              
  Lines        2110     2113       +3     
==========================================
+ Hits         1177     1180       +3     
  Misses        810      810              
  Partials      123      123              
Impacted Files Coverage Δ
pkg/report/writer.go 67.70% <100.00%> (+1.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update add65f2...d03ce95. Read the comment docs.

@simar7 simar7 self-requested a review July 31, 2020 17:12
@simar7 simar7 merged commit 52feff2 into aquasecurity:master Jul 31, 2020
liamg pushed a commit that referenced this pull request Jun 7, 2022
* Added template fucntion to escape string before output

* Fixed tests
josedonizetti pushed a commit to josedonizetti/trivy that referenced this pull request Jun 24, 2022
Signed-off-by: Owen Rumney <owen.rumney@aquasec.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants