Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(report): support for filtering licenses and secrets via rego policy files #6004

Conversation

kristyko
Copy link
Contributor

Description

Support filtering licenses and secrets through rego policy files

Related issues

  • Close #XXX

Discussion: #5730

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @kristyko
Thanks for your work!

LGTM.
I left a few comments.
Please also update docs.
Also i think you can add examples for secret and license to basic.rego example file.

Regards, Dmitriy

pkg/result/filter.go Outdated Show resolved Hide resolved
pkg/result/filter.go Outdated Show resolved Hide resolved
Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Left 1 small comment to avoid confusion.

About error in PR title:
We don't currently support multiple scopes.
So I think feat(report): support for filtering licenses and secrets via rego policy files will be sufficient.

pkg/result/filter_test.go Outdated Show resolved Hide resolved
@kristyko kristyko changed the title feat(license, secrets): support filtering licenses and secrets through rego policy files feat(report): support for filtering licenses and secrets via rego policy files Feb 12, 2024
@kristyko kristyko force-pushed the kristyko/support-secrets-and-licences-filter-by-rego-policy branch from 0d777f1 to c6d8461 Compare February 15, 2024 20:36
@kristyko
Copy link
Contributor Author

^ just rebased on the main branch

Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks a lot!

LGTM.
@knqyf263 I approved this PR. Take a look, please.

Copy link
Collaborator

@knqyf263 knqyf263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@knqyf263 knqyf263 added this pull request to the merge queue Feb 16, 2024
Merged via the queue into aquasecurity:main with commit c6844a7 Feb 16, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants