refactor(deps): Merge defsec into Trivy #6006
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 25, 2024
simar7
commented
Jan 25, 2024
| @@ -434,3 +433,5 @@ replace oras.land/oras-go => oras.land/oras-go v1.2.4-0.20230801060855-932dd06d3 | |||
| // testcontainers-go has a bug with versions v0.25.0 and v0.26.0 | |||
| // ref: https://github.com/testcontainers/testcontainers-go/issues/1782 | |||
| replace github.com/testcontainers/testcontainers-go => github.com/testcontainers/testcontainers-go v0.23.0 | |||
|
|
|||
| replace github.com/aquasecurity/trivy-aws => /Users/simarpreetsingh/repos/trivy-aws | |||
There was a problem hiding this comment.
This PR requires the changes here to be merged.
simar7
commented
Jan 27, 2024
Comment on lines
+19
to
+30
| type State struct { | ||
| AWS aws.AWS | ||
| Azure azure.Azure | ||
| CloudStack cloudstack.CloudStack | ||
| DigitalOcean digitalocean.DigitalOcean | ||
| GitHub github.GitHub | ||
| Google google.Google | ||
| Kubernetes kubernetes.Kubernetes | ||
| OpenStack openstack.OpenStack | ||
| Oracle oracle.Oracle | ||
| Nifcloud nifcloud.Nifcloud | ||
| } |
There was a problem hiding this comment.
@nikpivkin the state will live as an importable package in the Trivy repo. What do you think?
|
Close in favor of #6109 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is stacked PR on top of #6005
Merges defsec into Trivy + trivy-iac branch.
Related issues
trivy-iacinto Trivy #5626Related PRs
Checklist