Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc): add CWE-ID #614

Merged
merged 1 commit into from Sep 2, 2020
Merged

feat(rpc): add CWE-ID #614

merged 1 commit into from Sep 2, 2020

Conversation

knqyf263
Copy link
Collaborator

Related

#561

Note

We can fix integration tests after this PR.

@knqyf263 knqyf263 requested a review from simar7 August 26, 2020 08:33
@knqyf263 knqyf263 self-assigned this Aug 26, 2020
@codecov
Copy link

codecov bot commented Aug 26, 2020

Codecov Report

Merging #614 into master will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #614      +/-   ##
==========================================
- Coverage   56.15%   56.14%   -0.01%     
==========================================
  Files          44       44              
  Lines        2137     2139       +2     
==========================================
+ Hits         1200     1201       +1     
- Misses        811      812       +1     
  Partials      126      126              
Impacted Files Coverage Δ
pkg/rpc/convert.go 38.70% <50.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed8607b...3c978f4. Read the comment docs.

@simar7
Copy link
Member

simar7 commented Aug 26, 2020

@knqyf263
Copy link
Collaborator Author

knqyf263 commented Aug 27, 2020

I see. VendorVectors has nothing to do with cwe-id, so can we merge this PR once?

Copy link
Member

@simar7 simar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah let's merge this but we still need another PR to get parity.

@knqyf263 knqyf263 merged commit d8b0962 into master Sep 2, 2020
@knqyf263 knqyf263 deleted the feat/add_cweid branch September 2, 2020 04:42
liamg pushed a commit that referenced this pull request Jun 7, 2022
josedonizetti pushed a commit to josedonizetti/trivy that referenced this pull request Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants