Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(terraform): fix root module search #6160

Merged
merged 5 commits into from
Feb 28, 2024
Merged

fix(terraform): fix root module search #6160

merged 5 commits into from
Feb 28, 2024

Conversation

nikpivkin
Copy link
Contributor

@nikpivkin nikpivkin commented Feb 19, 2024 •
edited
Loading

Description

Modules with count = 0 were counted as root modules. This PR changes the way root modules are defined.

Related issues

Related PRs:

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nikpivkin nikpivkin marked this pull request as ready for review February 21, 2024 13:51
@simar7 simar7 added this pull request to the merge queue Feb 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Feb 27, 2024
@simar7 simar7 added this pull request to the merge queue Feb 28, 2024
Merged via the queue into aquasecurity:main with commit 1dfece8 Feb 28, 2024
12 checks passed
dus7eh pushed a commit to dus7eh/trivy that referenced this pull request Mar 6, 2024
@nikpivkin @simar7 @dus7eh
fix(terraform): fix root module search (aquasecurity#6160)
33ffa84 
Co-authored-by: simar7 <1254783+simar7@users.noreply.github.com>
@aqua-bot aqua-bot mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simar7 simar7 simar7 approved these changes

@knqyf263 knqyf263 Awaiting requested review from knqyf263

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(terraform): modules with the count meta-argument are not ignored
2 participants
@nikpivkin @simar7