feat(java): add support for fetching packages from repos mentioned in pom.xml #6171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description This change allows packages to be fetched from repository other than https://repo.maven.apache.org/maven2/ Get username and password from settings file for the corresponding server ID mentioned in the pom file Added support for authentication if username and password mentioned while fetching the package
renypaul
changed the title
renypaul
changed the title
DmitriyLewen
changed the title
There was a problem hiding this comment.
@renypaul I refactor a bit.
Also i found that we added repos for each pom file(see my comment).
Can you take a look?
knqyf263
reviewed
Feb 21, 2024
- Added comments where there credentials are fetched - Updated the order of the repo to reduce the number of tries to fetch - Avoid fetching pom file without version, since it will anyways fail in the tries
knqyf263
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
LGTM, but @DmitriyLewen has more insights. I'd defer to him.
|
Thanks @DmitriyLewen @knqyf263 |
This was referenced Mar 22, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change allows packages to be fetched from repository other than https://repo.maven.apache.org/maven2/
Get username and password from settings file for the corresponding server ID mentioned in the pom file Added support for authentication if username and password mentioned while fetching the package
Related issues
Related PRs
Checklist