Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Gitlab CI installation step in README #621

Merged
merged 1 commit into from Sep 2, 2020

Conversation

chr4
Copy link
Contributor

@chr4 chr4 commented Sep 1, 2020

This improves the installation step in .gitlab-ci.yml.

  • Removes unnecessary installation and use of curl (replaces it with wget)
  • Removes storing the intermediate file by using a pipe to tar
  • Rename VERSION to TRIVY_VERSION, to circumvent ambiguities in case there's other version variables in the CI configuration

This improves the installation step in `.gitlab-ci.yml`. 

- Removes unnecessary installation and use of `curl` (replaces it with `wget`)
- Removes storing the intermediate file by using a pipe to `tar`
@CLAassistant
Copy link

CLAassistant commented Sep 1, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #621 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #621   +/-   ##
=======================================
  Coverage   54.85%   54.85%           
=======================================
  Files          48       48           
  Lines        2297     2297           
=======================================
  Hits         1260     1260           
  Misses        907      907           
  Partials      130      130           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d35e8ec...d86b438. Read the comment docs.

@knqyf263 knqyf263 merged commit 165d593 into aquasecurity:master Sep 2, 2020
@knqyf263
Copy link
Collaborator

knqyf263 commented Sep 2, 2020

Thanks!

liamg pushed a commit that referenced this pull request Jun 7, 2022
This improves the installation step in `.gitlab-ci.yml`. 

- Removes unnecessary installation and use of `curl` (replaces it with `wget`)
- Removes storing the intermediate file by using a pipe to `tar`
josedonizetti pushed a commit to josedonizetti/trivy that referenced this pull request Jun 24, 2022
Bumps [helm.sh/helm/v3](https://github.com/helm/helm) from 3.8.2 to 3.9.0.
- [Release notes](https://github.com/helm/helm/releases)
- [Commits](helm/helm@v3.8.2...v3.9.0)

---
updated-dependencies:
- dependency-name: helm.sh/helm/v3
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Owen Rumney <owen.rumney@aquasec.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants