Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(misconf): Support private registries for misconf check bundle #6327

Merged
merged 3 commits into from
Apr 1, 2024

Conversation

JeffResc
Copy link
Contributor

Description

This proposed change allows the policy bundle repository specified with --policy-bundle-repository to be pulled from a private registry using specified username and password.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@CLAassistant
Copy link

CLAassistant commented Mar 14, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@nikpivkin nikpivkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knqyf263
Copy link
Collaborator

We're planning to cut v0.50.1. We'll merge this PR after that.

@dabo-devconsole
Copy link

Really nice! Just what I'm currently facing with. You mentioned --username + --password. Will --registry-token (oauth) also be possible?

@simar7
Copy link
Member

simar7 commented Mar 27, 2024

Really nice! Just what I'm currently facing with. You mentioned --username + --password. Will --registry-token (oauth) also be possible?

This PR just passes along the currently supported registry options by Trivy which are documented here.

@knqyf263 knqyf263 added this pull request to the merge queue Apr 1, 2024
Merged via the queue into aquasecurity:main with commit f23ed77 Apr 1, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(misconf): Support private registries for misconf check bundle
7 participants