Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws): apply filter options to result #6367

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

nikpivkin
Copy link
Contributor

Description

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nikpivkin nikpivkin marked this pull request as ready for review March 21, 2024 11:13
Copy link
Member

@simar7 simar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@simar7
Copy link
Member

simar7 commented Mar 26, 2024

we'll merge once the patch release is out, so v0.51.0 I believe. cc @knqyf263 correct me if I'm wrong.

@simar7 simar7 added this pull request to the merge queue Mar 29, 2024
Merged via the queue into aquasecurity:main with commit 09e37b7 Mar 29, 2024
12 checks passed
@nikpivkin nikpivkin deleted the aws-filter branch March 29, 2024 05:02
@itaysk
Copy link
Contributor

itaysk commented Apr 9, 2024

don't we need to update the docs?

@nikpivkin
Copy link
Contributor Author

@itaysk Do you mean we need to add filtering support information for AWS scan results here? AWS scanning refers to finding misconfigurations, and this page states that misconfigurations are supported.

@itaysk
Copy link
Contributor

itaysk commented Apr 9, 2024

ok, so if the documentation already indicated that it is supported, then it should be a bug not a feature.

are there any other cases where the availability of a feature is dependent on the target being scanned? if so, perhaps it worth adding the target matrix to the docs, or better to support all targets

@nikpivkin
Copy link
Contributor Author

@itaysk I'll check it out.

@simar7
Copy link
Member

simar7 commented Apr 9, 2024

ok, so if the documentation already indicated that it is supported, then it should be a bug not a feature.

are there any other cases where the availability of a feature is dependent on the target being scanned? if so, perhaps it worth adding the target matrix to the docs, or better to support all targets

It's here https://aquasecurity.github.io/trivy/v0.50/docs/configuration/filtering/#by-finding-ids

fl0pp5 pushed a commit to altlinux/trivy that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(cloud): Add support for filtering by misconf ID
3 participants