Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump up Go to 1.15 #646

Merged
merged 2 commits into from Sep 24, 2020
Merged

chore: bump up Go to 1.15 #646

merged 2 commits into from Sep 24, 2020

Conversation

knqyf263
Copy link
Collaborator

darwin/386 is no longer supported.
https://golang.org/doc/go1.15#darwin

@knqyf263 knqyf263 self-assigned this Sep 22, 2020
@codecov
Copy link

codecov bot commented Sep 22, 2020

Codecov Report

Merging #646 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #646   +/-   ##
=======================================
  Coverage   53.62%   53.62%           
=======================================
  Files          48       48           
  Lines        2025     2025           
=======================================
  Hits         1086     1086           
  Misses        808      808           
  Partials      131      131

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c786de...77b0401. Read the comment docs.

@knqyf263 knqyf263 mentioned this pull request Sep 22, 2020
Merged
simar7
simar7 reviewed Sep 22, 2020
View reviewed changes
goreleaser.yml
@@ -19,6 +19,9 @@ builds:
- arm64
goarm:
- 7
ignore:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't leave a comment on that line but should this be removed? https://github.com/aquasecurity/trivy/pull/646/files#diff-39e929907e3737ff7460d982cb6fbc60R41

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this https://github.com/aquasecurity/trivy/pull/646/files#diff-39e929907e3737ff7460d982cb6fbc60R17

Or I guess in general all occurrences of 386?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should continue to support linux/386. This ignore section affects only darwin/386.

Copy link
Member

@simar7 simar7 Sep 23, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see – I misread it to be 386 in general.

@knqyf263 knqyf263 merged commit 014be7e into master Sep 24, 2020
@knqyf263 knqyf263 deleted the go_115 branch September 24, 2020 05:00
liamg pushed a commit that referenced this pull request Jun 7, 2022
@knqyf263
chore: bump up Go to 1.15 (#646)
10bfd40 
* chore: bump up Go to 1.15

* chore(goreleaser): ignore darwin/386
josedonizetti pushed a commit to josedonizetti/trivy that referenced this pull request Jun 24, 2022
@liamg
fix(terraform): Prevent panics when block keys are unresolvable (aqua…
20fe63a 
…security#646)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simar7 simar7 simar7 approved these changes

Assignees

@knqyf263 knqyf263

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@knqyf263 @simar7